AllPivots

Originally Posted by alamehmazen123@gmail.com

dear Igor,
a perfect indicator indeed (ALLPIVOTs V5.6).
but when i am using it in an expert advisor, as iCustom(), i get the "array out of range indicator"
what could be wrong ?
thank you

Hi,

It looks like no enough bars to calculate pivots. This issue can happen if you set too large TimeFrame, Length or AvgPeriods periods.

Regards,
Igor

dear,
i tried everything to solve it, but still gives me the same problem

it points out to the line in the section below:

//+------------------------------------------------------------------+
int StrToDoubleArray(string str, double &a[], string delim=",", int _init=0)
//+------------------------------------------------------------------+
// Breaks down a single string into double array 'a' (elements delimited by 'delim')
// e.g. string is "1,2,3,4,5"; if delim is "," then the result will be
// a[0]=1.0 a[1]=2.0 a[2]=3.0 a[3]=4.0 a[4]=5.0
// Unused array elements are initialized by value in 'init' (default is 0)
{
int z1=-1, z2=0;

if(str == "") return(0);
if(StringRight(str,1) != delim) str = str + delim;

int strcnt = StringFindCount(str,delim);

ArrayResize(a,strcnt);

for(int i=0;i<strcnt;i++) a[i] = _init;


for(int i=0;i<strcnt;i++)
{
z2 = StringFind(str,delim,z1+1);
if(z2 > z1 + 1) a[i] = StrToNumber(StringSubstr(str,z1 + 1,z2 - z1 - 1));
if(z2 >= StringLen(str) - 1) break;
z1 = z2;
}

return(strcnt);
}

Originally Posted by alamehmazen123@gmail.com

dear,
i tried everything to solve it, but still gives me the same problem

it points out to the line in the section below:

//+------------------------------------------------------------------+
int StrToDoubleArray(string str, double &a[], string delim=",", int _init=0)
//+------------------------------------------------------------------+
// Breaks down a single string into double array 'a' (elements delimited by 'delim')
// e.g. string is "1,2,3,4,5"; if delim is "," then the result will be
// a[0]=1.0 a[1]=2.0 a[2]=3.0 a[3]=4.0 a[4]=5.0
// Unused array elements are initialized by value in 'init' (default is 0)
{
int z1=-1, z2=0;

if(str == "") return(0);
if(StringRight(str,1) != delim) str = str + delim;

int strcnt = StringFindCount(str,delim);

ArrayResize(a,strcnt);

for(int i=0;i<strcnt;i++) a[i] = _init;


for(int i=0;i<strcnt;i++)
{
z2 = StringFind(str,delim,z1+1);
if(z2 > z1 + 1) a[i] = StrToNumber(StringSubstr(str,z1 + 1,z2 - z1 - 1));
if(z2 >= StringLen(str) - 1) break;
z1 = z2;
}

return(strcnt);
}

Hi,

This function is used only in the OnInit() function.
Could you show the AllPivots settings in your EA?

Regards,
Igor

double Pivot= iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,5,0,0);
double R_1 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,5,1,0);
double R_2 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,5,2,0);
double S_1 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,4,7,0);
double S_2 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,4,8,0);

Originally Posted by alamehmazen123@gmail.com

double Pivot= iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,5,0,0);
double R_1 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,5,1,0);
double R_2 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,5,2,0);
double S_1 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,4,7,0);
double S_2 = iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "AllPivots", 1, "floor_piv", "0;1;2;3", "Previous Median", 0, false, "hilo_r", 1,0,0,4,8,0);

Hi,

I see that you use the wrong input parameters for iCustom() function because you should use ENUMs described in the indicator instead of the string inputs. Plus all parameters should be the same type and in the same order as in the indicator.

Regards,
Igor

dear,
thanks for the instructions, so i am now using the below settings:

Code:

double Pivot=  iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "Fibo", "1", "floor_piv", "0;1;2;3", "median", "0","hilo_r", "1", "0","0","5","", "true", "false", "true", "clrWhite", "1", "clrMaroon", "clrDarkGreen", "STYLE_SOLID", "2", "false", "clrSilver", "true", "STYLE_DOT", "0", "false", "Arial", "8", "clrWhite", "true", "right", "true", "clrGray", "FALSE", "clrBlack","true", "false", 0,0);

Code:

double R_1 =   iCustom(NULL, 0, "AllPivots_v5.6 600+", "", "D1", "Fibo", "1", "floor_piv", "0;1;2;3", "median", "0","hilo_r", "1", "0","0","5","", "true", "false", "true", "clrWhite", "1", "clrMaroon", "clrDarkGreen", "STYLE_SOLID", "2", "false", "clrSilver", "true", "STYLE_DOT", "0", "false", "Arial", "8", "clrWhite", "true", "right", "true", "clrGray", "FALSE", "clrBlack","true", "false", 1,0);

and it's working pretty fine now, BUT, i still have 2 problems:
1-when i use a large history data, say from January 2017 till today, it gives me the following message:
"AllPivots_v5.6 600+ EURUSD,H1: not enough memory for EX4 file"

2-when i make several backtesting consecutively, it crashes, then it gives me the same error (array out of range).
so i usually solve the issue by closing the MT4 terminal and re-launch it...it solve the problem.
my question is is it the issue from my terminal it-slef? or from the indicator (loaded with information)?

Hi Igor,

2 pictures. #1 Correct yearly pivots ( Daily chart ). #2 Incorrect yearly pivots ( Weekly chart ) (MT4)
It's very strange because the Monthly chart seems to plot the yearly pivots correctly.

best regards and happy holidays, Xander

Originally Posted by dndyFX

Hi Igor,

2 pictures. #1 Correct yearly pivots ( Daily chart ). #2 Incorrect yearly pivots ( Weekly chart ) (MT4)
It's very strange because the Monthly chart seems to plot the yearly pivots correctly.

best regards and happy holidays, Xander

Hi dndyFX,

As I mentioned already the AllPivots indicator builds pivots using the current chart data. And Because of that for the Yearly pivots on the W1 chart we should look "inside" of bars to find the correct prices for January,1 and December,31 of each year almost always . So in this case I suggest do not use the AllPivots on larger than D1 timeframes.


Regards,
Igor

Hello Igorad, not sure why, but sometimes id place pending orders on the DOTS level and when i go to a chart, it refreshes and it seems like the DOTS level refresh and move?
is this normal?